[KAFKA-13020] SnapshotReader should decode and report the append time in the header

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5.0
• Assignee: Jose Armando Garcia Sancio
• Reporter: Jose Armando Garcia Sancio
• Created: 30/Jun/21 20:38
• Updated: 10/Apr/23 18:15
• Resolved: 10/Apr/23 18:15

Description

We want to expose control messages through o.a.k.r.Batch and RecordsIterator. This can be done by turning the type Batch<T> into an interface and adding the type ControlBatch implements Batch<?> and DataBatch<T> implements Batch<T>. The main different between DataBatch<T> and ControlBatch is that control record have a decoder that knows how to decode LeaderChangeMessage, SnapshotHeaderRecord and SnapshotFooterRecord.

These are the import type and signatures that we expose:

1. class RecordsIterator<T> implements Iterator<Batch<T>> this type will keep the current signature but it will be extended to know how to decode both Data and Control batches
2. interface BatchReader<T> extends Iterator<DataBatch<T>> this type only returns data batches
3. class SnapshotReader<T> implements Iterator<DataBatch<T>> this type only returns data batches but when it reads the header record it remembers the last contained log timestamp

Issue Links

• links to: GitHub Pull Request #13345