[KAFKA-12667] Incorrect error log on StateDirectory close

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.0, 2.6.1, 2.8.0
• Fix Version/s: 2.6.3, 2.7.2, 2.8.1, 3.0.0
• Component/s: streams
• Assignee: A. Sophie Blee-Goldman
• Reporter: Jan Justesen
• Created: 14/Apr/21 07:07
• Updated: 14/Apr/21 20:12
• Resolved: 14/Apr/21 20:12

Description

In StateDirectory.close() an error is logged about unclean shutdown if all locks are in fact released, and nothing is logged in case of an unclean shutdown.

 

// all threads should be stopped and cleaned up by now, so none should remain holding a lock
if (locks.isEmpty()) {
 log.error("Some task directories still locked while closing state, this indicates unclean shutdown: {}", locks);
}

 

Issue Links

• links to: GitHub Pull Request #10536