[KAFKA-12613] Inconsistencies between Kafka Config and Log Config

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Component/s: core
• Assignee: Dongjin Lee
• Reporter: Dongjin Lee
• Created: 04/Apr/21 09:21
• Updated: 14/Apr/22 10:00
• Resolved: 14/Apr/22 10:00

Description

I found this problem while investigating KAFKA-8926.

Some broker-wide configurations (defined in KafkaConfig) are mapped with log-wide configurations (defined in LogConfig), providing a default value. You can find the complete mapping list in `LogConfig.TopicConfigSynonyms`.

The problem is, some configuration properties' validation is different between KafkaConfig and LogConfig:

These inconsistencies cause some problems with the dynamic configuration feature. When a user dynamically configures the broker configuration with `AdminClient#alterConfigs`, the submitted config is validated with KafkaConfig, which lacks some validation logic - as a result, they bypasses the correct validation.

For example, a user can set `log.cleaner.min.cleanable.ratio` to -0.5 - which is obviously prohibited in LogConfig.

• I could not reproduce the situation KAFKA-8926 describes, but fixing this problem also resolves KAFKA-8926.

Issue Links

• relates to: KAFKA-8926 Log Cleaner thread dies when log.cleaner.min.cleanable.ratio is set to 0
• links to: GitHub Pull Request #10472