[KAFKA-12381] Incompatible change in verifiable_producer.log in 2.8

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.0
• Component/s: core
• Labels: kip-500
• Assignee: Boyang Chen
• Reporter: Colin McCabe
• Created: 27/Feb/21 00:50
• Updated: 06/Mar/21 06:46
• Resolved: 06/Mar/21 06:46

Description

In test_verifiable_producer.py , we used to see this error message in verifiable_producer.log when a topic couldn't be created:

WARN [Producer clientId=producer-1] Error while fetching metadata with correlation id 1 :

{test_topic=LEADER_NOT_AVAILABLE}

(org.apache.kafka.clients.NetworkClient)
The test does a grep LEADER_NOT_AVAILABLE on the log in this case, and it used to pass.

Now we are instead seeing this in the log file:

WARN [Producer clientId=producer-1] Error while fetching metadata with correlation id 1 :

{test_topic=INVALID_REPLICATION_FACTOR}

(org.apache.kafka.clients.NetworkClient)
And of course now the test fails.

The INVALID_REPLICATION_FACTOR is coming from the new auto topic creation manager.

It is a simple matter to make the test pass – I have confirmed that it passes if we grep for INVALID_REPLICATION_FACTOR in the log file instead of LEADER_NOT_AVAILABLE.

I think we just need to decide if this change in behavior is acceptable or not.

Issue Links

• links to: GitHub Pull Request #10240