[KAFKA-12340] Recent change to use SharedTopicAdmin results in potential resource leak in deprecated backing store constructors

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.5.2, 2.8.0, 2.7.1, 2.6.2
• Fix Version/s: 2.5.2, 2.8.0, 2.7.1, 2.6.2
• Component/s: connect
• Assignee: Randall Hauch
• Reporter: Randall Hauch
• Reviewer: Konstantine Karantasis
• Created: 18/Feb/21 18:53
• Updated: 22/Feb/21 16:11
• Resolved: 22/Feb/21 16:11

Description

When KAFKA-10021 modified the Connect `Kafka*BackingStore` classes, we deprecated the old constructors and changed all uses within AK to use the new constructors that take a `Supplier<TopicAdmin>`.

If the old deprecated constructors are used (outside of AK), then they will not close the Admin clients that are created by the "default" supplier.

Issue Links

• is caused by: KAFKA-10021 When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms
• links to: GitHub Pull Request #10153