[KAFKA-12187] replace assertTrue(obj instanceof X) by assertInstanceOf when we update to JUnit 5.8

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.8.0
• Assignee: Kuan Po Tseng
• Reporter: Chia-Ping Tsai
• Created: 13/Jan/21 14:16
• Updated: 20/Mar/24 02:36
• Resolved: 20/Mar/24 02:36

Description

see https://github.com/apache/kafka/pull/9874#discussion_r556547909

 

Yeah, for existing code improvements (versus code introduced by this change), let's do it via a different PR. For this particular issue, we can probably wait for JUnit 5.8 and use:

• New assertInstanceOf methods as a replacement for assertTrue(obj instanceof X) which provide better error messages comparable to those of assertThrows.

 related PR: https://github.com/junit-team/junit5/pull/2499

Issue Links

• links to: GitHub Pull Request #15512