Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1131

copy some more files into the release tar and zip that are needed/desired

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      e.g. LICENSE, NOTICE, README (or maybe a new quick start file .txt)

        Activity

        Hide
        charmalloc Joe Stein added a comment -

        Created reviewboard https://reviews.apache.org/r/15503/
        against branch trunk

        Show
        charmalloc Joe Stein added a comment - Created reviewboard https://reviews.apache.org/r/15503/ against branch trunk
        Hide
        mumrah David Arthur added a comment -

        Joe Stein, patch looks good, verified that it adds NOTICE and LICENSE in the release directory.

        Two quick questions:

        • Do we need to include these in the jar for the binary dist, or just for Maven?
        • If I'm reading http://apache.org/legal/src-headers.html#notice right, we need to include 3rd party licenses in the NOTICE file of the binary dist (since we are distributing those 3rd party libs). I know Ivy can generate a list of all the licenses, so SBT probably can as well.
        Show
        mumrah David Arthur added a comment - Joe Stein , patch looks good, verified that it adds NOTICE and LICENSE in the release directory. Two quick questions: Do we need to include these in the jar for the binary dist, or just for Maven? If I'm reading http://apache.org/legal/src-headers.html#notice right, we need to include 3rd party licenses in the NOTICE file of the binary dist (since we are distributing those 3rd party libs). I know Ivy can generate a list of all the licenses, so SBT probably can as well.
        Hide
        joestein Joe Stein added a comment -

        << Do we need to include these in the jar for the binary dist, or just for Maven?
        probably, yeah, good point

        << If I'm reading http://apache.org/legal/src-headers.html#notice right, we need to include 3rd party licenses in the NOTICE file of the binary dist (since we are distributing those 3rd party libs). I know Ivy can generate a list of all the licenses, so SBT probably can as well.

        this should all be correct as we haven't made any changes since incubation and it was resolved then. we are only bumping into these jar issues now because we only released and signed source for 0.7.X

        Show
        joestein Joe Stein added a comment - << Do we need to include these in the jar for the binary dist, or just for Maven? probably, yeah, good point << If I'm reading http://apache.org/legal/src-headers.html#notice right, we need to include 3rd party licenses in the NOTICE file of the binary dist (since we are distributing those 3rd party libs). I know Ivy can generate a list of all the licenses, so SBT probably can as well. this should all be correct as we haven't made any changes since incubation and it was resolved then. we are only bumping into these jar issues now because we only released and signed source for 0.7.X

          People

          • Assignee:
            Unassigned
            Reporter:
            joestein Joe Stein
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development