[KAFKA-10885] Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of (unnecessary) ignored test cases

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Labels: newbie
• Assignee: GeordieMai
• Reporter: Chia-Ping Tsai
• Created: 23/Dec/20 06:01
• Updated: 18/Feb/21 03:16
• Resolved: 18/Feb/21 03:16

Description

private void assumeAtLeastV2OrNotZstd(byte magic)
Unknown macro: { assumeTrue(compressionType != CompressionType.ZSTD || magic >= MAGIC_VALUE_V2); }

MemoryRecordsBuilderTest/MemoryRecordsTest use aforementioned method to avoid testing zstd on unsupported magic code. However, it produces some unnecessary ignored test cases. Personally, it could be separated to different test classes for each magic code as we do assign specify magic code to each test cases.
 
 

Issue Links

• links to: GitHub Pull Request #9906