Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-10841

LogReadResult should be able to converted to FetchPartitionData

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.8.0
    • None

    Description

      There are duplicate code which try to convert LogReadResult to FetchPartitionData. It seems to me the duplicate code can be eliminated by moving the conversion to LogReadResult.

      occurrence 1: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L1076

      occurrence 2:
      https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/DelayedFetch.scala#L189

      Attachments

        Issue Links

          Activity

            People

              Geordie GeordieMai
              chia7712 Chia-Ping Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: