[KAFKA-10832] Recovery logic is using incorrect ProducerStateManager instance when updating producers

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0
• Assignee: Kowshik Prakasam
• Reporter: Kowshik Prakasam
• Created: 09/Dec/20 19:53
• Updated: 12/Dec/20 00:37
• Resolved: 12/Dec/20 00:37

Description

The bug is that from within Log.updateProducers(…), the code operates on the producerStateManager attribute of the Log instance instead of operating on an input parameter. Please see this LOC where it calls producerStateManager.prepareUpdate thus accessing the attribute from the Log object (see this). This looks unusual particularly for Log.loadProducersFromLog(...) path. Here I believe we should be using the instance passed to the method, rather than the attribute from the Log instance.

Issue Links

• links to: GitHub Pull Request #9718