[KAFKA-10800] Validate the snapshot id when the state machine creates a snapshot

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: replication
• Assignee: Haoran Xuan
• Reporter: Jose Armando Garcia Sancio
• Created: 03/Dec/20 01:09
• Updated: 14/Nov/21 14:22
• Resolved: 26/Oct/21 21:04

Description

When the state machine attempts to create a snapshot writer we should validate that the following is true:

1. The end offset of the snapshot is less than or equal to the high-watermark.
2. The epoch of the snapshot is less than or equal to the quorum epoch.
3. The end offset and epoch of the snapshot is valid based on the leader epoch cache.

Note that this validation should not be performed when the raft client creates the snapshot writer because in that case the local log is out of date and the follower should trust the snapshot id sent by the partition leader.

Issue Links

• is blocked by: KAFKA-10394 Internal API for generating snapshots
• is blocked by: KAFKA-10761 In Raft support nonzero start offset and SnapshotId for the Fetch request handling
• links to: GitHub Pull Request #10593