[KAFKA-10531] KafkaBasedLog can sleep for negative values

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0, 2.5.2, 2.6.1
• Component/s: core
• Assignee: Vikas Singh
• Reporter: Vikas Singh
• Reviewer: Randall Hauch
• Created: 28/Sep/20 20:01
• Updated: 05/Oct/20 19:45
• Resolved: 05/Oct/20 19:45

Description

time.milliseconds is not monotonic, so this code can throw :

java.lang.IllegalArgumentException: timeout value is negative

 

        long started = time.milliseconds();
        while (partitionInfos == null && time.milliseconds() - started < CREATE_TOPIC_TIMEOUT_MS) {
            partitionInfos = consumer.partitionsFor(topic);
            Utils.sleep(Math.min(time.milliseconds() - started, 1000));
        }

We need to check for negative value before sleeping.

Issue Links

• links to: GitHub Pull Request #9347