[KAFKA-10469] Respect logging hierarchy (KIP-676)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0
• Component/s: core
• Assignee: Tom Bentley
• Reporter: Tom Bentley
• Created: 08/Sep/20 16:15
• Updated: 07/Jan/21 05:18
• Resolved: 10/Nov/20 14:26

Description

Log4jController#loggers incorrectly uses the root logger's log level for any loggers which lack a configured log level of their own. This is incorrect because loggers without an explicit level inherit their level from their parent logger and this resolved level might be different from the root logger's level. This means that the levels reported from Admin.describeConfigs, which uses Log4jController#loggers are incorrect. This can be shown by using the default log4j.properties and describing a broker's loggers, it reports

kafka.controller=TRACE
kafka.controller.ControllerChannelManager=INFO
kafka.controller.ControllerEventManager$ControllerEventThread=INFO
kafka.controller.KafkaController=INFO
kafka.controller.RequestSendThread=INFO
kafka.controller.TopicDeletionManager=INFO
kafka.controller.ZkPartitionStateMachine=INFO
kafka.controller.ZkReplicaStateMachine=INFO

The default log4j.properties does indeed set kafka.controller to TRACE, but it does not configure the others, so they're actually at TRACE not INFO as reported.

Issue Links

• links to: GitHub Pull Request #9266
• links to: KIP-676
• mentioned in: Page Loading...