Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1035

Add message-send-max-retries and retry-backoff-ms options to console producer

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.7, 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: producer
    • Labels:

      Description

      It's possible for console producer to give up too soon if it can't find a leader of a topic. Increasing message-send-max-retries would resolve this but. Console producer doesn't provide options to set message-send-max-retries and retry-backoff-ms.

      1. console_producer_add_options.patch
        3 kB
        Rajasekar Elango
      2. console_producer_add_options-v2.patch
        4 kB
        Rajasekar Elango

        Activity

        Hide
        erajasekar Rajasekar Elango added a comment -

        Patch for fixing this.

        Show
        erajasekar Rajasekar Elango added a comment - Patch for fixing this.
        Show
        erajasekar Rajasekar Elango added a comment - See attachment for patch https://issues.apache.org/jira/secure/attachment/12600604/console_producer_add_options.patch
        Hide
        guozhang Guozhang Wang added a comment -

        Thanks for the patch. One minor comment:

        Could you modify the description of message-send-max-retries:

        "The leader may be unavailable transiently, which can fail the sending of a message. This property specifies the number of retries when such failures occur"?

        1. Brokers can fail receiving the message for multiple reasons, and being unavailable transiently is just one of them.
        2. This properties specifies the number of retires before the producer give up and drop this message.

        Show
        guozhang Guozhang Wang added a comment - Thanks for the patch. One minor comment: Could you modify the description of message-send-max-retries: "The leader may be unavailable transiently, which can fail the sending of a message. This property specifies the number of retries when such failures occur"? 1. Brokers can fail receiving the message for multiple reasons, and being unavailable transiently is just one of them. 2. This properties specifies the number of retires before the producer give up and drop this message.
        Hide
        erajasekar Rajasekar Elango added a comment -

        Sure. do you want me to change description as
        "Brokers can fail receiving the message for multiple reasons, and being unavailable transiently is just one of them.This properties specifies the number of retires before the producer give up and drop this message."

        Show
        erajasekar Rajasekar Elango added a comment - Sure. do you want me to change description as "Brokers can fail receiving the message for multiple reasons, and being unavailable transiently is just one of them.This properties specifies the number of retires before the producer give up and drop this message."
        Hide
        guozhang Guozhang Wang added a comment -

        That is fine.

        Show
        guozhang Guozhang Wang added a comment - That is fine.
        Hide
        erajasekar Rajasekar Elango added a comment -

        Attached patch with modified description. Please review.

        Show
        erajasekar Rajasekar Elango added a comment - Attached patch with modified description. Please review.
        Hide
        guozhang Guozhang Wang added a comment -

        Looks good to me. +1

        Show
        guozhang Guozhang Wang added a comment - Looks good to me. +1
        Hide
        erajasekar Rajasekar Elango added a comment -

        Thanks, So could you apply patch and commit changes to repo.

        Raja.

        Show
        erajasekar Rajasekar Elango added a comment - Thanks, So could you apply patch and commit changes to repo. Raja.
        Hide
        guozhang Guozhang Wang added a comment -

        Sorry but I am not one of the committers.. Can someone (Jun Rao,Neha Narkhede,Joel Koshy) review/commit it?

        Show
        guozhang Guozhang Wang added a comment - Sorry but I am not one of the committers.. Can someone ( Jun Rao , Neha Narkhede , Joel Koshy ) review/commit it?
        Hide
        junrao Jun Rao added a comment -

        Thanks for the patch. +1. Committed to 0.8.

        Show
        junrao Jun Rao added a comment - Thanks for the patch. +1. Committed to 0.8.

          People

          • Assignee:
            erajasekar Rajasekar Elango
            Reporter:
            erajasekar Rajasekar Elango
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development