Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-10316

Consider renaming getter method for Interactive Queries

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0
    • Component/s: streams
    • Labels:

      Description

      In the 2.5 release, we introduce new classes for Interactive Queries via KIP-535 (cf https://issues.apache.org/jira/browse/KAFKA-6144). The KIP did not specify the names for getter methods of `KeyQueryMetadata` explicitly and they were added in the PR as `getActiveHost()`, `getStandbyHosts()`, and `getPartition()`.

      However, in Kafka it is custom to not use the `get` prefix for getters and thus the methods should have been added as `activeHost()`, `standbyHosts()`, and `partition()`, respectively.

      We should consider renaming the methods accordingly, by deprecating the existing ones and adding the new ones in parallel.

      KIP-648: https://cwiki.apache.org/confluence/display/KAFKA/KIP-648%3A+Renaming+getter+method+for+Interactive+Queries

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                johnthotekat John Thomas
                Reporter:
                mjsax Matthias J. Sax
                Reviewer:
                Matthias J. Sax
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2.5h
                  2.5h