Kafka
  1. Kafka
  2. KAFKA-1018

tidy up the POM from what feedback has come from the 0.8 beta and publishing to maven

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      from Chris Riccomini

      1. Maven central can't resolve it properly (POM is different from Apache release). Have to use Apache release repo directly to get things to work.
      2. Exclusions must be manually applied even though they exist in Kafka's POM already. I think Maven can handle this automatically, if the POM is done right.
      3. Weird parent block in Kafka POMs that points to org.apache.
      4. Would be nice to publish kafka-test jars as well.
      5. Would be nice to have SNAPSHOT releases off of trunk using a Hudson job.
      Our hypothesis regarding the first issue is that it was caused by duplicate publishing during testing, and it should go away in the future.
      Regarding number 2, I have to explicitly exclude the following when depending on Kafka:
      exclude module: 'jms'
      exclude module: 'jmxtools'
      exclude module: 'jmxri'
      I believe these just need to be excluded from the appropriate jars in the actual SBT build file, to fix this issue. I see JMS is excluded from ZK, but it's probably being pulled in from somewhere else, anyway.
      Regarding number 3, it is indeed listed as something to do on the Apache publication page (http://www.apache.org/dev/publishing-maven-artifacts.html). I can't find an example of anyone using it, but it doesn't seem to be doing any harm.
      Also, regarding your intransitive() call, that is disabling ALL dependencies not just the exclusions, I believe. I think that the "proper" way to do that would be to do what I've done: exclude("jms", "jmxtools", "jmxri"). Regardless, fixing number 2, above, should mean that intransitive()/exclude() are not required.

      1. KAFKA-1018.patch
        1 kB
        Joe Stein
      2. KAFKA-1018.patch
        1 kB
        Joe Stein
      3. KAFKA-1018.patch
        1 kB
        Joe Stein
      4. KAFKA-1018.patch
        1 kB
        Joe Stein
      5. KAFKA-1018.patch
        1 kB
        Joe Stein
      6. KAFKA-1018.patch
        1 kB
        Joe Stein
      7. KAFKA-1018.patch
        1 kB
        Joe Stein

        Activity

        Hide
        Neha Narkhede added a comment -

        Joe Stein This is marked for the 0.8 final release. Do you think you could help look into this?

        Show
        Neha Narkhede added a comment - Joe Stein This is marked for the 0.8 final release. Do you think you could help look into this?
        Hide
        Joe Stein added a comment - - edited

        1) maven central is immutable, resolved in this coming release
        2) I think your right, yup. This was fixed on branch after found in maven central.
        3) just going by the docs
        4) I have a fix for this I am testing right now
        5) yup, agreed. I can create one patch for trunk and one for the 0.8 branch, leave trunk on SNAPSHOT and then another JIRA for hooking it up to hudson I gotta look into that

        The changes I am testing are in a repo here http://ec2-54-224-196-57.compute-1.amazonaws.com:8081/nexus/content/repositories/releases with the pom of http://ec2-54-224-196-57.compute-1.amazonaws.com:8081/nexus/content/repositories/releases/org/apache/kafka/kafka_2.10/0.8.0/kafka_2.10-0.8.0.pom

        I am running into some issues I am bumping into while testing, working that out now

        Show
        Joe Stein added a comment - - edited 1) maven central is immutable, resolved in this coming release 2) I think your right, yup. This was fixed on branch after found in maven central. 3) just going by the docs 4) I have a fix for this I am testing right now 5) yup, agreed. I can create one patch for trunk and one for the 0.8 branch, leave trunk on SNAPSHOT and then another JIRA for hooking it up to hudson I gotta look into that The changes I am testing are in a repo here http://ec2-54-224-196-57.compute-1.amazonaws.com:8081/nexus/content/repositories/releases with the pom of http://ec2-54-224-196-57.compute-1.amazonaws.com:8081/nexus/content/repositories/releases/org/apache/kafka/kafka_2.10/0.8.0/kafka_2.10-0.8.0.pom I am running into some issues I am bumping into while testing, working that out now
        Hide
        Joe Stein added a comment -
        Show
        Joe Stein added a comment - Created reviewboard https://reviews.apache.org/r/14571/
        Hide
        Jun Rao added a comment -

        Could you double commit this to trunk? Thanks,

        Show
        Jun Rao added a comment - Could you double commit this to trunk? Thanks,
        Hide
        Joe Stein added a comment -

        yup, done

        Show
        Joe Stein added a comment - yup, done

          People

          • Assignee:
            Unassigned
            Reporter:
            Joe Stein
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development