Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-10111

SinkTaskContext.errantRecordReporter() added in KIP-610 should be a default method

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.6.0
    • Component/s: KafkaConnect
    • Labels:
      None

      Description

      KIP-610 added a new `errantRecordReporter()` method to `SinkTaskContext`, but the KIP didn't make this method a default method. While the AK project can add this method to all of its implementations (actual and test), other projects such as connector projects might have their own mock implementations just to help test the connector implementation. That means when those projects upgrade, they'd get compilation problems for their own implementations of `SinkTaskContext`.

      Making this method default will save such problems with downstream projects, and is actually easy since the method is already defined to return null if no reporter is configured.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                rhauch Randall Hauch
                Reporter:
                rhauch Randall Hauch
                Reviewer:
                Konstantine Karantasis
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: