[KAFKA-10094] In MirrorSourceConnector replace two-step assignment with single call

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Component/s: mirrormaker
• Labels: newbie
• Assignee: Mandar Tillu
• Reporter: Jakob Homan
• Created: 03/Jun/20 20:47
• Updated: 06/Jun/20 18:03
• Resolved: 05/Jun/20 23:01

Description

n.b. This is a newbie ticket designed to be an introduction to contributing for the assignee.

 

In MirrorSourceConnector::refreshTopicPartitions we have places where we create a new HashSet and then addAll to the set.  We can replace both with a direct call to the copy constructor.

 

    void refreshTopicPartitions()
            throws InterruptedException, ExecutionException {
        knownSourceTopicPartitions = findSourceTopicPartitions();
        knownTargetTopicPartitions = findTargetTopicPartitions();
        List<TopicPartition> upstreamTargetTopicPartitions = knownTargetTopicPartitions.stream()
                .map(x -> new TopicPartition(replicationPolicy.upstreamTopic(x.topic()), x.partition()))
                .collect(Collectors.toList());

        Set<TopicPartition> newTopicPartitions = new HashSet<>();
        newTopicPartitions.addAll(knownSourceTopicPartitions);
        newTopicPartitions.removeAll(upstreamTargetTopicPartitions);
        Set<TopicPartition> deadTopicPartitions = new HashSet<>();
        deadTopicPartitions.addAll(upstreamTargetTopicPartitions);

 

 

Issue Links

• links to: GitHub Pull Request #8797