Kafka
  1. Kafka
  2. KAFKA-1004

Handle topic event for trivial whitelist topic filters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7, 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      Toay consumer's TopicEventWatcher is not subscribed with trivial whitelist topic names. Hence if the topic is not registered on ZK when the consumer is started, it will not trigger the rebalance of consumers later when it is created and hence not be consumed even if it is in the whilelist. A proposed fix would be always subscribe TopicEventWatcher for all whitelist consumers.

      1. KAFKA-1004.v2.patch
        4 kB
        Guozhang Wang
      2. KAFKA-1004.v1.patch
        1 kB
        Guozhang Wang

        Activity

        Hide
        Joel Koshy added a comment -

        This was fixed in KAFKA-1103

        Show
        Joel Koshy added a comment - This was fixed in KAFKA-1103
        Hide
        Jun Rao added a comment -

        Looks good to me. Joel, do you want to take another look?

        Show
        Jun Rao added a comment - Looks good to me. Joel, do you want to take another look?
        Hide
        Guozhang Wang added a comment -

        Good point. v2 applied.

        Also removed part of the topic watcher registration comment, since I think for now we would register the consumer no matter if its allowed topics becomes available.

        Show
        Guozhang Wang added a comment - Good point. v2 applied. Also removed part of the topic watcher registration comment, since I think for now we would register the consumer no matter if its allowed topics becomes available.
        Hide
        Jun Rao added a comment -

        Thanks for the patch. That looks good. However, shouldn't we just remove requiresTopicEventWatcher from TopicFilter completely?

        Show
        Jun Rao added a comment - Thanks for the patch. That looks good. However, shouldn't we just remove requiresTopicEventWatcher from TopicFilter completely?

          People

          • Assignee:
            Guozhang Wang
            Reporter:
            Guozhang Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development