Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-10029

Selector.completedReceives should not be modified when channel is closed

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.5.0
    • 2.6.0, 2.5.1
    • network
    • None

    Description

      Selector.completedReceives are processed using `forEach` by SocketServer and NetworkClient when processing receives from a poll. Since we may close channels while processing receives, changes to the map while closing channels can result in ConcurrentModificationException. We clear the entire map after each poll anyway, so we don't need to remove channel from the map while closing channels.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rsivaram Rajini Sivaram
            rsivaram Rajini Sivaram
            Ismael Juma Ismael Juma
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment