[JUDDI-372] Inquiry Helper improperly uses assignment operator on lists.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 3.0.1
• Fix Version/s: 3.0.2
• Component/s: core
• Assignee: Jeff Faath
• Reporter: Adam Pryce
• Created: 05/Mar/10 19:06
• Updated: 24/May/11 21:35
• Resolved: 06/Mar/10 00:22

Description

In trying to work out a subscription I found what I believe is an improper use of assignment in InquiryHelper.java.
From : http://svn.apache.org/viewvc/webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/InquiryHelper.java?view=markup

264 public static List<?> findService(FindService body, FindQualifiers findQualifiers, EntityManager em) throws DispositionReportFaultMessage

{ 265 266 List<?> keysFound = null; 267 268 // First perform the embedded FindTModel search which will augment the tModel bag with any resulting tModel keys. 269 if (body.getTModelBag() == null) 270 body.setTModelBag(new TModelBag()); 271 doFindTModelEmbeddedSearch(em, body.getFindQualifiers(), body.getFindTModel(), body.getTModelBag()); 272 273 274 keysFound = FindServiceByTModelKeyQuery.select(em, findQualifiers, body.getTModelBag(), body.getBusinessKey(), keysFound); 275 keysFound = FindServiceByCategoryQuery.select(em, findQualifiers, body.getCategoryBag(), body.getBusinessKey(), keysFound); 276 keysFound = FindServiceByCategoryGroupQuery.select(em, findQualifiers, body.getCategoryBag(), body.getBusinessKey(), keysFound); 277 keysFound = FindServiceByNameQuery.select(em, findQualifiers, body.getName(), body.getBusinessKey(), keysFound); 278 279 if (body.getTModelBag().getTModelKey().size()==0) body.setTModelBag(null); 280 return keysFound; 281 }

I think 274-277 should use something like
keysFound.addAll(FindServiceBy*)
Unfortunately in my environment I cannot build or test this.