JSPWiki
  1. JSPWiki
  2. JSPWIKI-750

PageViewPluginTest is failing very often when using a JDK 7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.4, 2.9
    • Fix Version/s: 2.9
    • Labels:
      None
    • Environment:

      Oracle JDK 7

      Description

      The PageViewPluginTest tests will fail if they aren't executed in the same order like they appear in the source file.
      JUnit never gave any grants in terms of execution ordering. Quite the contrary, relying on execution ordering is considered to be bad practice [1].
      However, up to JDK 6, it seemed to always be the same ordering like in the source code, so the tests were thought to be stable and deterministic. JDK 7 now changed this situation [2].

      Thanks to Glen Mazza for reporting this [3]!

      [1] http://www.javaworld.com/jw-12-2000/jw-1221-junit.html?page=2
      [2] http://stackoverflow.com/questions/3693626/how-to-run-test-methods-in-spec-order-in-junit4
      [3] http://mail-archives.apache.org/mod_mbox/incubator-jspwiki-dev/201210.mbox/%3C508C0CBB.4030304%40gmail.com%3E

        Issue Links

          Activity

          Hide
          Florian Holeczek added a comment -

          Because of JSPWIKI-665, I took the small solution and implemented the workaround mentioned at [1] (see above). Seems to work, couldn't reproduce the test failures anymore.

          Show
          Florian Holeczek added a comment - Because of JSPWIKI-665 , I took the small solution and implemented the workaround mentioned at [1] (see above). Seems to work, couldn't reproduce the test failures anymore.
          Hide
          Florian Holeczek added a comment -

          Closing this, since 2.9 has been released

          Show
          Florian Holeczek added a comment - Closing this, since 2.9 has been released

            People

            • Assignee:
              Florian Holeczek
              Reporter:
              Florian Holeczek
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development