Details

      Description

      Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.

      JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.

        Issue Links

          Activity

          Hide
          Mike Morris added a comment -

          Proposed fix for missing getParentLogger under 1.7.

          Show
          Mike Morris added a comment - Proposed fix for missing getParentLogger under 1.7.
          Hide
          Juan Pablo Santos Rodríguez added a comment -

          Hello Mike,

          unfortunately, we can't apply the attached patch: the build is targetted for Java 1.5 and the patch breaks this:

          • first, it uses SQLFeatureNotSupportedException, which is only available under Java 6 and onwards.
          • second, it's annotated with @Override, which, under a JDK6 (or downwards) isn't true.

          So, to include the patch, getParentLogger should not throw any exception in its signature (also it could possibly return null), and it should not be annotated with @Override

          It would be nice to have this in the upcoming RC, so if you attach a new patch we can include it on trunk + 2.8 branch.

          Show
          Juan Pablo Santos Rodríguez added a comment - Hello Mike, unfortunately, we can't apply the attached patch: the build is targetted for Java 1.5 and the patch breaks this: first, it uses SQLFeatureNotSupportedException, which is only available under Java 6 and onwards. second, it's annotated with @Override, which, under a JDK6 (or downwards) isn't true. So, to include the patch, getParentLogger should not throw any exception in its signature (also it could possibly return null), and it should not be annotated with @Override It would be nice to have this in the upcoming RC, so if you attach a new patch we can include it on trunk + 2.8 branch.
          Hide
          Juan Pablo Santos Rodríguez added a comment -

          fixed in 2.9.0-svn-7 and 2.8.5-svn-11

          Show
          Juan Pablo Santos Rodríguez added a comment - fixed in 2.9.0-svn-7 and 2.8.5-svn-11
          Hide
          Florian Holeczek added a comment -

          Closing this, since 2.9 has been released

          Show
          Florian Holeczek added a comment - Closing this, since 2.9 has been released

            People

            • Assignee:
              Unassigned
              Reporter:
              Mike Morris
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development