Details

      Description

      Attempting to build under JDK 1.7 causes a compile failure on test class org.apache.wiki.TestJDBCDataSource.

      JDK1.7 introduces a new method getParentLogger() in javax.sql.CommonDataSource which is not implemented by TestJDBCDataSource.

        Issue Links

          Activity

          Florian Holeczek made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Florian Holeczek added a comment -

          Closing this, since 2.9 has been released

          Show
          Florian Holeczek added a comment - Closing this, since 2.9 has been released
          Florian Holeczek made changes -
          Link This issue relates to JSPWIKI-277 [ JSPWIKI-277 ]
          Florian Holeczek made changes -
          Original Estimate 10m [ 600 ]
          Remaining Estimate 10m [ 600 ]
          Labels newbie
          Juan Pablo Santos Rodríguez made changes -
          Link This issue duplicates JSPWIKI-277 [ JSPWIKI-277 ]
          Juan Pablo Santos Rodríguez made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 2.8.5 [ 12315288 ]
          Fix Version/s 2.9 [ 12319521 ]
          Resolution Fixed [ 1 ]
          Hide
          Juan Pablo Santos Rodríguez added a comment -

          fixed in 2.9.0-svn-7 and 2.8.5-svn-11

          Show
          Juan Pablo Santos Rodríguez added a comment - fixed in 2.9.0-svn-7 and 2.8.5-svn-11
          Hide
          Juan Pablo Santos Rodríguez added a comment -

          Hello Mike,

          unfortunately, we can't apply the attached patch: the build is targetted for Java 1.5 and the patch breaks this:

          • first, it uses SQLFeatureNotSupportedException, which is only available under Java 6 and onwards.
          • second, it's annotated with @Override, which, under a JDK6 (or downwards) isn't true.

          So, to include the patch, getParentLogger should not throw any exception in its signature (also it could possibly return null), and it should not be annotated with @Override

          It would be nice to have this in the upcoming RC, so if you attach a new patch we can include it on trunk + 2.8 branch.

          Show
          Juan Pablo Santos Rodríguez added a comment - Hello Mike, unfortunately, we can't apply the attached patch: the build is targetted for Java 1.5 and the patch breaks this: first, it uses SQLFeatureNotSupportedException, which is only available under Java 6 and onwards. second, it's annotated with @Override, which, under a JDK6 (or downwards) isn't true. So, to include the patch, getParentLogger should not throw any exception in its signature (also it could possibly return null), and it should not be annotated with @Override It would be nice to have this in the upcoming RC, so if you attach a new patch we can include it on trunk + 2.8 branch.
          Mike Morris made changes -
          Field Original Value New Value
          Attachment getParentLoggerPatch.diff [ 12516322 ]
          Hide
          Mike Morris added a comment -

          Proposed fix for missing getParentLogger under 1.7.

          Show
          Mike Morris added a comment - Proposed fix for missing getParentLogger under 1.7.
          Mike Morris created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Mike Morris
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development