JSPWiki
  1. JSPWiki
  2. JSPWIKI-721

Log FileNotFoundException on missing attachment

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.4
    • Fix Version/s: 2.8.5, 2.9
    • Component/s: Core & storage
    • Labels:
      None

      Description

      We messed with the repository and had an attachment folder without the actual attachment. This results in a FileNotFoundException in
      BasicAttachmentProvider.getAttachmentInfo(WikiPage, String, int)
      and comes up as the infamous
      java.lang.IllegalArgumentException: Attempt to provide a null filter - this should never happen. Please check your configuration (or if you're a developer, check your own code.)
      at com.ecyrd.jspwiki.filters.FilterManager.addPageFilter(FilterManager.java:145)

      A log in the FileNotFoundException catch block would help a lot:

      catch( FileNotFoundException e )

      { log.error("Can't get attachment properties for "+att, e ); return null; }

        Activity

        Hide
        Harry Metske added a comment -

        Fixed in 2.8.5-svn-10 and 2.9.0-svn-6.

        Show
        Harry Metske added a comment - Fixed in 2.8.5-svn-10 and 2.9.0-svn-6.
        Hide
        Florian Holeczek added a comment -

        Closing this, since 2.9 has been released

        Show
        Florian Holeczek added a comment - Closing this, since 2.9 has been released

          People

          • Assignee:
            Harry Metske
            Reporter:
            Jürgen Weber
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development