Details

    • Type: Test Test
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: Graduating
    • Fix Version/s: Graduating
    • Component/s: Core & storage
    • Labels:
      None
    • Environment:

      All

      Description

      The current 3.0.0-svn trunk build has about 50+ failing unit tests. That isn't bad, but we need a clean build before we graduate. Specific areas of focus are:

      • ReferenceManager
      • PageRenamer
      • Index and Reference-related plugins

        Issue Links

          Activity

          Juan Pablo Santos Rodríguez made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Juan Pablo Santos Rodríguez added a comment -

          Bulk resolved -> close state issue transition

          Show
          Juan Pablo Santos Rodríguez added a comment - Bulk resolved -> close state issue transition
          Juan Pablo Santos Rodríguez made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Juan Pablo Santos Rodríguez added a comment -

          Fixed DefaultAclManagerTest.testPrintAcl(). Saving pages involves calling RenderingManager.getRenderedDocument(), which can return cached or non-cached WikiDocuments.

          In the first case, ACLs were not associated to current WikiPage, whereas in the second one yes (DefaultAclManager.parseAcl() is called as part of MarkupParser.parse()).

          Also, 27 tests where locale-dependant (test assertions assumed english locale), so TestEngine and WikiContextFactory enforce it when building mock requests.

          Show
          Juan Pablo Santos Rodríguez added a comment - Fixed DefaultAclManagerTest.testPrintAcl(). Saving pages involves calling RenderingManager.getRenderedDocument(), which can return cached or non-cached WikiDocuments. In the first case, ACLs were not associated to current WikiPage, whereas in the second one yes (DefaultAclManager.parseAcl() is called as part of MarkupParser.parse()). Also, 27 tests where locale-dependant (test assertions assumed english locale), so TestEngine and WikiContextFactory enforce it when building mock requests.
          Hide
          Juan Pablo Santos Rodríguez added a comment -

          Also, there are about 20 unit tests that are locale sensitive: they check localized text against unlocalized, english Strings, so they fail when the default locale is not set to english.

          Show
          Juan Pablo Santos Rodríguez added a comment - Also, there are about 20 unit tests that are locale sensitive: they check localized text against unlocalized, english Strings, so they fail when the default locale is not set to english.
          Hide
          Henri Yandell added a comment -

          Noting that there are only 2 failing unit tests currently:

          http://people.apache.org/~metskem/tests/junit-noframes.html

          Show
          Henri Yandell added a comment - Noting that there are only 2 failing unit tests currently: http://people.apache.org/~metskem/tests/junit-noframes.html
          Andrew Jaquith made changes -
          Field Original Value New Value
          Link This issue blocks JSPWIKI-461 [ JSPWIKI-461 ]
          Andrew Jaquith created issue -

            People

            • Assignee:
              Janne Jalkanen
              Reporter:
              Andrew Jaquith
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development