JSPWiki
  1. JSPWiki
  2. JSPWIKI-545

Check that only ASL and/or ASL-compatible licenses are used.

        Details

        • Type: Task Task
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: Graduating
        • Component/s: None
        • Labels:
          None

          Description

          Only ASL can be used in source code. Under this task, we can discuss any deviations thereof (like binary licenses).

          An (old) list of dependencies is at http://www.jspwiki.org/wiki/ApacheRelicensing

          1. Text File
            rat-3.0.0-svn-132.txt
            461 kB
            Janne Jalkanen
          2. Text File
            rat-3.0.0-svn-129.txt
            493 kB
            Harry Metske
          3. Text File
            rat-3.0.0-svn-127.txt
            652 kB
            Harry Metske
          4. Text File
            rat-3.0.0-svn-126.txt
            610 kB
            Janne Jalkanen
          5. Text File
            rat-3.0.0-svn-125.txt
            1.10 MB
            Janne Jalkanen

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            Janne Jalkanen added a comment -

            Calling it closed.

            Show
            Janne Jalkanen added a comment - Calling it closed.
            Hide
            Permalink
            Harry Metske added a comment -

            Janne, do you want to keep this one open (if not then please close it) ?

            Show
            Harry Metske added a comment - Janne, do you want to keep this one open (if not then please close it) ?
            Hide
            Permalink
            Janne Jalkanen added a comment -

            We'll need to re-run RAT right before a release... But that could be made a part of the release process.

            Show
            Janne Jalkanen added a comment - We'll need to re-run RAT right before a release... But that could be made a part of the release process.
            Hide
            Permalink
            Harry Metske added a comment -

            +1 for closing this one.

            Show
            Harry Metske added a comment - +1 for closing this one.
            Hide
            Permalink
            Andrew Jaquith added a comment -

            Can we close this?

            Show
            Andrew Jaquith added a comment - Can we close this?
            Hide
            Permalink
            Janne Jalkanen added a comment -

            RAT run against 3.0.0-svn-132.

            I think this is pretty complete now, and I can't see anything else that we could possibly add a license header to anymore.

            Show
            Janne Jalkanen added a comment - RAT run against 3.0.0-svn-132. I think this is pretty complete now, and I can't see anything else that we could possibly add a license header to anymore.
            Hide
            Permalink
            Harry Metske added a comment -

            Sorry for the mess I made, I'll be more careful next time.

            Show
            Harry Metske added a comment - Sorry for the mess I made, I'll be more careful next time.
            Hide
            Permalink
            Janne Jalkanen added a comment -

            ...and you broke plenty of code as well.

            Also, Eclipse-generated XML files should not be commented, since any save will remove all comments anyway.

            We don't have to make the RAT issues go to zero, just have no unexplained ones.

            Show
            Janne Jalkanen added a comment - ...and you broke plenty of code as well. Also, Eclipse-generated XML files should not be commented, since any save will remove all comments anyway. We don't have to make the RAT issues go to zero, just have no unexplained ones.
            Hide
            Permalink
            Harry Metske added a comment -

            fixed a couple of rat issues, still more needed.

            Show
            Harry Metske added a comment - fixed a couple of rat issues, still more needed.
            Hide
            Permalink
            Janne Jalkanen added a comment -

            Report for 3.0.0-svn-126.

            Show
            Janne Jalkanen added a comment - Report for 3.0.0-svn-126.
            Hide
            Permalink
            Janne Jalkanen added a comment -

            Not sure how we can make RAT ignore built files, such as the ones under /build/.

            Files under /doc/ are a bit confusing - do they explicitly need to be licensed under ASL?

            Many of the property files need ASL:

            /Users/jalkanen/Eclipse/JSPWiki/etc/priha.properties
            /Users/jalkanen/Eclipse/JSPWiki/etc/db/hsql/server.properties
            /Users/jalkanen/Eclipse/JSPWiki/etc/db/hsql/userdb-setup.ddl
            /Users/jalkanen/Eclipse/JSPWiki/etc/db/hsql/userdb-teardown.ddl
            /Users/jalkanen/Eclipse/JSPWiki/etc/db/postgresql/userdb-setup.ddl
            /Users/jalkanen/Eclipse/JSPWiki/etc/db/postgresql/userdb-teardown.ddl
            /Users/jalkanen/Eclipse/JSPWiki/etc/schema/j2ee_1_4.xsd
            /Users/jalkanen/Eclipse/JSPWiki/etc/schema/jsp_2_0.xsd
            /Users/jalkanen/Eclipse/JSPWiki/etc/schema/web-app_2_4.xsd

            PT_BR is missing license:

            /Users/jalkanen/Eclipse/JSPWiki/src/WebContent/WEB-INF/classes/CoreResources_pt_BR.properties
            /Users/jalkanen/Eclipse/JSPWiki/src/WebContent/WEB-INF/classes/plugin/PluginResources_pt_BR.properties
            /Users/jalkanen/Eclipse/JSPWiki/src/WebContent/WEB-INF/classes/templates/default_pt_BR.properties

            Following source files are missing license:

            /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/package.html
            /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/content/MissingParameterException.java
            /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/event/ContentEvent.java
            /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/tags/SpamProtectTag.java
            /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/ui/stripes/SpamInterceptor.java
            /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/ui/stripes/SpamProtect.java
            /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/url/package.html

            The wikipages are missing a license, but I think that's fine, since there's no way we can put a license on them without confusing the heck out of everybody.

            There are still a lot of non-source files under /tests/ which are missing ASL.

            Show
            Janne Jalkanen added a comment - Not sure how we can make RAT ignore built files, such as the ones under /build/. Files under /doc/ are a bit confusing - do they explicitly need to be licensed under ASL? Many of the property files need ASL: /Users/jalkanen/Eclipse/JSPWiki/etc/priha.properties /Users/jalkanen/Eclipse/JSPWiki/etc/db/hsql/server.properties /Users/jalkanen/Eclipse/JSPWiki/etc/db/hsql/userdb-setup.ddl /Users/jalkanen/Eclipse/JSPWiki/etc/db/hsql/userdb-teardown.ddl /Users/jalkanen/Eclipse/JSPWiki/etc/db/postgresql/userdb-setup.ddl /Users/jalkanen/Eclipse/JSPWiki/etc/db/postgresql/userdb-teardown.ddl /Users/jalkanen/Eclipse/JSPWiki/etc/schema/j2ee_1_4.xsd /Users/jalkanen/Eclipse/JSPWiki/etc/schema/jsp_2_0.xsd /Users/jalkanen/Eclipse/JSPWiki/etc/schema/web-app_2_4.xsd PT_BR is missing license: /Users/jalkanen/Eclipse/JSPWiki/src/WebContent/WEB-INF/classes/CoreResources_pt_BR.properties /Users/jalkanen/Eclipse/JSPWiki/src/WebContent/WEB-INF/classes/plugin/PluginResources_pt_BR.properties /Users/jalkanen/Eclipse/JSPWiki/src/WebContent/WEB-INF/classes/templates/default_pt_BR.properties Following source files are missing license: /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/package.html /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/content/MissingParameterException.java /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/event/ContentEvent.java /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/tags/SpamProtectTag.java /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/ui/stripes/SpamInterceptor.java /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/ui/stripes/SpamProtect.java /Users/jalkanen/Eclipse/JSPWiki/src/java/org/apache/wiki/url/package.html The wikipages are missing a license, but I think that's fine, since there's no way we can put a license on them without confusing the heck out of everybody. There are still a lot of non-source files under /tests/ which are missing ASL.
            Hide
            Permalink
            Janne Jalkanen added a comment -

            RAT report on 3.0.0-svn-125.

            Show
            Janne Jalkanen added a comment - RAT report on 3.0.0-svn-125.

              People

              • Assignee:
                Andrew Jaquith
                Reporter:
                Janne Jalkanen
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development