[JSPWIKI-30] Rename may cause dataloss

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.5.139-beta
• Fix Version/s: 2.8
• Component/s: Core & storage
• Assignee: Unassigned
• Reporter: Janne Jalkanen
• Created: 10/Nov/07 14:53
• Updated: 10/Sep/11 23:36
• Resolved: 07/Jun/08 21:36

Description

If rename fails due to an exception in PageRenamer, the end result may be wiping out of some of the pages that refer to the linking page. The preconditions seem to include a complicated link sentence. I managed to get this to happen on jspwiki.org by renaming page "MyCodingStandard" to "JSPWikiCodingStandard", which resulted in some of the renaming to fail. I think some of the links were of the form "my coding standard".

Suggested correction: let's get rid of the link "guesser", and just modify the actual link reference - and if it's missing, we'll add one.

Note that this is not real dataloss; you can still get the old page from the page history. It just causes a new, empty page to be put into the repository.