[JSPWIKI-1156] Remove 'protected' member in 'final' class

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Arturo Bernal
• Created: 01/Oct/21 16:36
• Updated: 28/Oct/21 10:08
• Resolved: 28/Oct/21 10:08

Description

Since final classes cannot be inherited, marking the method as protected may be confusing.
IMO It is better to declare such members as private or package-visible instead.

 

Of course I can be wrong.

Issue Links

• links to: GitHub Pull Request #141
• links to: JSPWIKI-1156 - Remove 'protected' member in 'final' class #141