Uploaded image for project: 'JSPWiki'
  1. JSPWiki
  2. JSPWIKI-1056

URL in registration mail is relative while it should be absolute

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 2.10.3
    • None
    • None
    • Java 8
      Tomcat 8
      JSPWiki 2.10.3-git-27

    Description

      After registering a new user with an email address, you get an email.

      This email used to contain a link to the login URL of your wiki, but after JSPWIKI-1035 this URL is relative.

      The relevant piece of code is : https://github.com/apache/jspwiki/blob/master/jspwiki-war/src/main/java/org/apache/wiki/auth/UserManager.java#L799

      What would be the most elegant way to get the absolute URL here ?

      Here's a stacktrace to that point:

      	at javax.mail.Transport.send(Transport.java:124)
      	at org.apache.wiki.util.MailUtil.sendMessage(MailUtil.java:287)
      	at org.apache.wiki.auth.UserManager$SaveUserProfileTask.execute(UserManager.java:801)
      	at org.apache.wiki.workflow.Workflow.processCurrentStep(Workflow.java:763)
      	at org.apache.wiki.workflow.Workflow.start(Workflow.java:678)
      	at org.apache.wiki.workflow.WorkflowManager.start(WorkflowManager.java:86)
      	at org.apache.wiki.auth.UserManager.setUserProfile(UserManager.java:366)
      	at org.apache.jsp.Login_jsp._jspService(Login_jsp.java:135)
      	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
      	at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:432)
      	at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
      	at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.apache.wiki.ui.WikiServletFilter.doFilter(WikiServletFilter.java:160)
      	at org.apache.wiki.ui.WikiJSPFilter.doFilter(WikiJSPFilter.java:113)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
      	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
      	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
      	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
      	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
      	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
      	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953)
      	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
      	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
      	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1041)
      	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:603)
      	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      	at java.lang.Thread.run(Thread.java:745)
      

      Attachments

        Issue Links

          Activity

            People

              metskem Harry Metske
              metskem Harry Metske
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: