Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.3
    • Component/s: None
    • Labels:
      None

      Description

      The current code uses per-thread pseudo-singletons. This requires complex and fragile sychronisation code.

      Factor out interfaces and inject dependencies. Any synchronisation required should be provided by the user of library.

      See http://mail-archives.apache.org/mod_mbox/james-server-dev/200708.mbox/%3cf470f68e0708061234p13943d3fm3497b6fdfff4d203@mail.gmail.com%3e thread for more details.

        Activity

        Robert Burrell Donkin created issue -
        Hide
        Robert Burrell Donkin added a comment -

        Requires refactoring. Release first.

        Show
        Robert Burrell Donkin added a comment - Requires refactoring. Release first.
        Robert Burrell Donkin made changes -
        Field Original Value New Value
        Resolution Later [ 7 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Stefano Bagnara made changes -
        Status Resolved [ 5 ] Reopened [ 4 ]
        Resolution Later [ 7 ]
        Stefano Bagnara made changes -
        Affects Version/s 0.2 [ 12312665 ]
        Hide
        Robert Burrell Donkin added a comment -

        The [pseudo-]singletons can be categorised into:

        • Entry point:
        • SieveFactory
        • Configuration:
        • ConfigurationManager
        • ComparatorManager
        • TestManager
        • CommandManager
        • Logger
        • Magic context:
        • ConditionManager
        • CommandStateManager

        Should be possible to factor magic context into a Context which is passed though on execution

        Should be possible to separate concerns about configuration from execution by creating interfaces and a default builder

        Show
        Robert Burrell Donkin added a comment - The [pseudo-] singletons can be categorised into: Entry point: SieveFactory Configuration: ConfigurationManager ComparatorManager TestManager CommandManager Logger Magic context: ConditionManager CommandStateManager Should be possible to factor magic context into a Context which is passed though on execution Should be possible to separate concerns about configuration from execution by creating interfaces and a default builder
        Hide
        Robert Burrell Donkin added a comment -

        Good enough for now

        Show
        Robert Burrell Donkin added a comment - Good enough for now
        Robert Burrell Donkin made changes -
        Fix Version/s 1.0 [ 12312666 ]
        Fix Version/s 0.3 [ 12313222 ]
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Robert Burrell Donkin made changes -
        Assignee Robert Burrell Donkin [ robertburrelldonkin ]

          People

          • Assignee:
            Robert Burrell Donkin
            Reporter:
            Robert Burrell Donkin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development