Jetspeed 2
  1. Jetspeed 2
  2. JS2-950

Improve Jetspeed statistics component

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.0, 2.2.1
    • Fix Version/s: 2.2.1
    • Component/s: Components Core
    • Labels:
      None

      Description

      Jetspeed statistics component needs improvement while writing to console or database.

        Activity

        Hide
        sebastien added a comment -

        I was using Jetspeed 2.1.3 in a projet with a lot of hits and I had to maximize the application throughput. With a lot of profiling of the application, I found few possible optimizations to the Jetspeed code and one of them was that the BatchedStatistics class was execively synchronizing. I had the chance to use a Java 1.5 environnement and I came with a patch using java.util.concurrent api and removing synchronize blocks.

        This patch was tested with jmeter and a profiler and proved to increase the server throughput. It is also in use in production environement for over a year without problems.

        Since Jetspeed 2.2 now require Java 1.5, I have ported this patch created for J-2.1.3 to J-2.2. The patch could be integrated in your code and I hope this could be my first stone to the project.

        Please feel free to ask questions about my implementation.

        Regards,

        Sebastien

        Show
        sebastien added a comment - I was using Jetspeed 2.1.3 in a projet with a lot of hits and I had to maximize the application throughput. With a lot of profiling of the application, I found few possible optimizations to the Jetspeed code and one of them was that the BatchedStatistics class was execively synchronizing. I had the chance to use a Java 1.5 environnement and I came with a patch using java.util.concurrent api and removing synchronize blocks. This patch was tested with jmeter and a profiler and proved to increase the server throughput. It is also in use in production environement for over a year without problems. Since Jetspeed 2.2 now require Java 1.5, I have ported this patch created for J-2.1.3 to J-2.2. The patch could be integrated in your code and I hope this could be my first stone to the project. Please feel free to ask questions about my implementation. Regards, Sebastien
        Hide
        Ate Douma added a comment -

        David, maybe we should review this patch and see if we can include this in 2.2.1 already if it doesn't have potential side-effects?

        Show
        Ate Douma added a comment - David, maybe we should review this patch and see if we can include this in 2.2.1 already if it doesn't have potential side-effects?
        Hide
        David Sean Taylor added a comment -

        we will review this patch, and include in upcoming release

        Show
        David Sean Taylor added a comment - we will review this patch, and include in upcoming release
        Hide
        Randy Watler added a comment -

        Patch reviewed and applied to 2.2.1. Not applied to 2.1.4 since it does not support Java 1.5 concurrent package.

        SVN commit: 925734

        Show
        Randy Watler added a comment - Patch reviewed and applied to 2.2.1. Not applied to 2.1.4 since it does not support Java 1.5 concurrent package. SVN commit: 925734

          People

          • Assignee:
            Randy Watler
            Reporter:
            Vivek Kumar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development