Jetspeed 2
  1. Jetspeed 2
  2. JS2-942

When there are no decorator defaults in root folder, causes stack trace in browser

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2-M1
    • Fix Version/s: 2.1.4, 2.2-M1
    • Component/s: Decorations/Themes
    • Labels:
      None

      Description

      During testing and usage, I suddenly started getting errors like:

      java.lang.NullPointerException
      org.apache.jetspeed.util.Path.splitPath(Path.java:288)
      org.apache.jetspeed.util.Path.<init>(Path.java:100)
      org.apache.jetspeed.util.Path.addSegment(Path.java:339)
      org.apache.jetspeed.decoration.DecorationFactoryImpl.getLayoutDecorationBasePath(DecorationFactoryImpl.java:469)

      I discovered that the PSML root folder.metadata had no default decorators. I am not sure if I somehow I deleted this XML element with the customizer (I don't remember doing so), or if its a bug in the system. I have never seen this bug in the 2.1.x branch, so I will keep an eye out for it happening again. This work provided to fix this issue will:

      • make the decorator factory defaults more robust, so that it can be configured to fallback to a system-wide default if it fails to find defaults anywhere else (like in the desktop)
      • configure a fatal exception handler in the Jetpeed Servlet so our end users do not have to view a stack trace

        Activity

        Hide
        David Sean Taylor added a comment -

        committed fix to 2.2, also backported decorator name check for null fix to 2.1.4

        Show
        David Sean Taylor added a comment - committed fix to 2.2, also backported decorator name check for null fix to 2.1.4

          People

          • Assignee:
            David Sean Taylor
            Reporter:
            David Sean Taylor
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development