Jetspeed 2
  1. Jetspeed 2
  2. JS2-921

Portal Site Manager portlet not save "unhidden" state for PSML

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.2.0
    • Component/s: Admin Portlets
    • Labels:
      None
    • Environment:
      Jetspeed 2.1.3, Tomcat 5.5.27, Mozilla Fierfox 3.0.5 or IE 7.0.5730.13, Windows XP

      Description

      Portal Site Manager / PSML / Information if "hidden" checkbox checked - uncheck state not save after click "save" button.

        Activity

        Hide
        Vivek Kumar added a comment -

        New Wicket Portal Site manager has been checked.
        This issue has been taken care in new portlet

        Show
        Vivek Kumar added a comment - New Wicket Portal Site manager has been checked. This issue has been taken care in new portlet
        Hide
        Vivek Kumar added a comment -

        Issue would be fixed with Wicket Portal site Manager

        Show
        Vivek Kumar added a comment - Issue would be fixed with Wicket Portal site Manager
        Hide
        Ilya A. Izergin added a comment -

        components/portal/src/java/org.apache.jetspeed.layout.impl.UpdatePageAction.java (updateInformation line 380)

        String hidden = getActionParameter(requestContext, "hidden");
        if (hidden != null && isBooleanModified(hidden, page.isHidden()))
        page.setHidden(!page.isHidden());

        any browsers return null for "unchecked" checkbox. I think replace it to

        boolean hidden = "true".equalsIgnoreCase(getActionParameter(requestContext, "hidden"));
        if( page.isHidden() != hidden)
        page.setHidden( hidden );

        Show
        Ilya A. Izergin added a comment - components/portal/src/java/org.apache.jetspeed.layout.impl.UpdatePageAction.java (updateInformation line 380) String hidden = getActionParameter(requestContext, "hidden"); if (hidden != null && isBooleanModified(hidden, page.isHidden())) page.setHidden(!page.isHidden()); any browsers return null for "unchecked" checkbox. I think replace it to boolean hidden = "true".equalsIgnoreCase(getActionParameter(requestContext, "hidden")); if( page.isHidden() != hidden) page.setHidden( hidden );

          People

          • Assignee:
            Vivek Kumar
            Reporter:
            Ilya A. Izergin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development