Jetspeed 2
  1. Jetspeed 2
  2. JS2-894

Deploy tool does not keep file dates in WAR file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.2.0
    • Component/s: Deployment
    • Labels:
      None
    • Environment:
      Seen on Windows 2000 and Windows XP. Not tested on any other platform

      Description

      After adding a jar full of custom tags (written as JSP scriptlets) to my project, Tomcat insisted on compiling every page plus the tags from the jar on every page access. Needless to say, performance was a bit pedestrian.

      Since then, I have researched the problem, but unfortunately it came right of its own accord - I cannot reproduce it. But I did notice that the re-packaged .war file emiited to Tomcat has all the file modification dates set to "now". I suspect the issue may arise when a run of the deploy tool spans two windows clock ticks.

      The fix is trivial - I will attach an updated source file

        Activity

        Ron McNulty created issue -
        Hide
        Ron McNulty added a comment -

        Patched JetspeedDeploy.java attached

        Show
        Ron McNulty added a comment - Patched JetspeedDeploy.java attached
        Ron McNulty made changes -
        Field Original Value New Value
        Attachment JetspeedDeploy.java [ 12386374 ]
        Ate Douma made changes -
        Assignee Ate Douma [ adouma ]
        Hide
        Ate Douma added a comment -

        Thanks Ron, I've looked at the patched file and your changes are sound.

        Note: it would be handier if you provide diff files instead of complete patched sources to make it easier to review and apply.

        I will commit these to the current trunk (Jetspeed-2.2-SNAPSHOT) as well to the 2.1.3-postrelease branch.

        Show
        Ate Douma added a comment - Thanks Ron, I've looked at the patched file and your changes are sound. Note: it would be handier if you provide diff files instead of complete patched sources to make it easier to review and apply. I will commit these to the current trunk (Jetspeed-2.2-SNAPSHOT) as well to the 2.1.3-postrelease branch.
        Hide
        Ate Douma added a comment -

        Patch applied both to the trunk (2.2-SNAPSHOT) and branch 2.1.3-postrelease.

        Thanks Ron.

        Show
        Ate Douma added a comment - Patch applied both to the trunk (2.2-SNAPSHOT) and branch 2.1.3-postrelease. Thanks Ron.
        Ate Douma made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.2 [ 12312318 ]
        Ate Douma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        13h 6m 1 Ate Douma 18/Jul/08 22:32
        Resolved Resolved Closed Closed
        1172d 23h 36m 1 Ate Douma 04/Oct/11 22:08

          People

          • Assignee:
            Ate Douma
            Reporter:
            Ron McNulty
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development