Jetspeed 2
  1. Jetspeed 2
  2. JS2-880

Full Wicket implementation of the admin portlets

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.2.1
    • Component/s: Admin Portlets
    • Labels:
      None

      Description

      We have a basic/example Wicket portlet implementation now for the User manager.
      But we need to expand/extend that portlet to provide the full functionalitiy needed, as well as support for the new security Preferences and attributes model implementation of JS2-869 and JS2-870.
      Furthermore, the other security and Site, Page, Profiler etc. portlet also should be rewritten using Wicket so we develop a common Wicket framework as standard for all admin portlets.

      Finally, the backed model used by Wicket should be abstracted such that a later replacement / further abstraction to use other backends like JCR or even flat XML storage is easy the incorporate.

      1. JS-880-remove-export-entities-api.patch
        0.8 kB
        Jeroen Hoffman
      2. JS-880-remove-export-entities.patch
        5 kB
        Jeroen Hoffman
      3. JS-880-removeAjaxExport.patch
        27 kB
        Jeroen Hoffman
      4. JS2-880-jetspeed-importexport.patch
        5 kB
        Jeroen Hoffman
      5. JS2-880-j2-admin-importexport.patch
        37 kB
        Jeroen Hoffman
      6. WicketPortletTrackingPortlet.diff
        16 kB
        Niels van Kampenhout
      7. WicketProfilerAdmin.diff
        36 kB
        Niels van Kampenhout

        Activity

        Hide
        Niels van Kampenhout added a comment -

        Attached is a patch (WicketProfilerAdmin.diff) against j2-admin trunk r737764 that adds a Profile Admin Portlet written in Wicket. The GUI needs to be (re)designed but all the functionality of the old JSF based portlet is present.

        Show
        Niels van Kampenhout added a comment - Attached is a patch (WicketProfilerAdmin.diff) against j2-admin trunk r737764 that adds a Profile Admin Portlet written in Wicket. The GUI needs to be (re)designed but all the functionality of the old JSF based portlet is present.
        Hide
        Ate Douma added a comment -

        Thanks Niels, great work!
        I've committed the new Wicket Profiler Admin and will also update the corresponding Administrative psml page to replace the old portlet with this one.

        Show
        Ate Douma added a comment - Thanks Niels, great work! I've committed the new Wicket Profiler Admin and will also update the corresponding Administrative psml page to replace the old portlet with this one.
        Hide
        Niels van Kampenhout added a comment -

        Here's another one. WicketPortletTrackingPortlet.diff contains a patch against j2-admin trunk r738316 that adds a wicketized version of the Portlet Tracking portlet.

        I only tested with mocked PortletDefinition objects since I do not know how to force portlets to be taken out of service....

        Show
        Niels van Kampenhout added a comment - Here's another one. WicketPortletTrackingPortlet.diff contains a patch against j2-admin trunk r738316 that adds a wicketized version of the Portlet Tracking portlet. I only tested with mocked PortletDefinition objects since I do not know how to force portlets to be taken out of service....
        Hide
        Ate Douma added a comment -

        Part of the admin portlets are already "Wicketized", but not everything.
        Full completion will be done for release 2.2.1

        Show
        Ate Douma added a comment - Part of the admin portlets are already "Wicketized", but not everything. Full completion will be done for release 2.2.1
        Hide
        Jeroen Hoffman added a comment -

        Two patches for the wicketizing the Import-Export Service.
        One for the j2-admin portlet, one for some psml changes in Jetspeed application. Note that the Ajax pipeline that exports objects is no longer used but still exists, will create a patch for that at a later stage if needed.

        Show
        Jeroen Hoffman added a comment - Two patches for the wicketizing the Import-Export Service. One for the j2-admin portlet, one for some psml changes in Jetspeed application. Note that the Ajax pipeline that exports objects is no longer used but still exists, will create a patch for that at a later stage if needed.
        Hide
        David Sean Taylor added a comment -

        Jeroen, Im testing it out a bit, and going to apply the patch shortly. One thing checked Portlet Entities but I didn't see any in the export file. Could you please retest? Thanks

        Show
        David Sean Taylor added a comment - Jeroen, Im testing it out a bit, and going to apply the patch shortly. One thing checked Portlet Entities but I didn't see any in the export file. Could you please retest? Thanks
        Hide
        Jeroen Hoffman added a comment -

        I retested and both checkboxes Portlet Entities and User Preferences don;t export anything. It is not a GUI bug, the checkbox values are indeed set as options in JetspeedSerializer.exportData.

        I see however that those options have no corresponding (inner) serializers configured in assembly/serializer.xml, which I think may very well be the cause. A JetspeedUserTemplateSerializer is commented out.

        So this is another issue IMO.

        Show
        Jeroen Hoffman added a comment - I retested and both checkboxes Portlet Entities and User Preferences don;t export anything. It is not a GUI bug, the checkbox values are indeed set as options in JetspeedSerializer.exportData. I see however that those options have no corresponding (inner) serializers configured in assembly/serializer.xml, which I think may very well be the cause. A JetspeedUserTemplateSerializer is commented out. So this is another issue IMO.
        Hide
        Ate Douma added a comment -

        That there are no Portlet Entities in the export might be explained because we're no longer using Portlet Entities... So, what's not there cannot be exported either

        Show
        Ate Douma added a comment - That there are no Portlet Entities in the export might be explained because we're no longer using Portlet Entities... So, what's not there cannot be exported either
        Hide
        David Sean Taylor added a comment -

        Looking at the JetspeedRegistrySerializer.java, all the code is commented out:

        /* TODO 2.2
        // do I carry any preferences?

        Lets see if we can find a solution to get this working again. See:

        https://issues.apache.org/jira/browse/JS2-971

        Show
        David Sean Taylor added a comment - Looking at the JetspeedRegistrySerializer.java, all the code is commented out: /* TODO 2.2 // do I carry any preferences? Lets see if we can find a solution to get this working again. See: https://issues.apache.org/jira/browse/JS2-971
        Hide
        Jeroen Hoffman added a comment -

        Attached a patch removing Ajax export related files that are unused since wicketizing Import/Export and the Portal Site Manager. See also my comment 10/Apr/09 07:35 AM.

        Show
        Jeroen Hoffman added a comment - Attached a patch removing Ajax export related files that are unused since wicketizing Import/Export and the Portal Site Manager. See also my comment 10/Apr/09 07:35 AM.
        Hide
        Jeroen Hoffman added a comment -

        Added a j2-admin patch for the Import/Export service to remove the Portlet Entities export option as those entities are no longer present (following up on Ate Douma's comment 17/Apr/09). Also a small accompanying patch for jetspeed-api.

        The j2-admin patch also contains a fix where choosing Permissions actually does trigger exporting Users/Groups/Roles, as the permissions label says.

        Show
        Jeroen Hoffman added a comment - Added a j2-admin patch for the Import/Export service to remove the Portlet Entities export option as those entities are no longer present (following up on Ate Douma's comment 17/Apr/09). Also a small accompanying patch for jetspeed-api. The j2-admin patch also contains a fix where choosing Permissions actually does trigger exporting Users/Groups/Roles, as the permissions label says.
        Hide
        David Sean Taylor added a comment -

        Vivek, as we discussed, Im going to assign you to finishing this up for the 2.2.0 final work. I will be committing the PAM (PRM) work today. Also, if you can take a look at the Import/Export and Preferences.

        Show
        David Sean Taylor added a comment - Vivek, as we discussed, Im going to assign you to finishing this up for the 2.2.0 final work. I will be committing the PAM (PRM) work today. Also, if you can take a look at the Import/Export and Preferences.

          People

          • Assignee:
            Vivek Kumar
            Reporter:
            Ate Douma
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 672h
              672h
              Remaining:
              Remaining Estimate - 672h
              672h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development