Jetspeed 2
  1. Jetspeed 2
  2. JS2-787

Non-informative error handling in PortalSiteManager. I've created a patch

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.1.3, 2.2.0
    • Component/s: Admin Portlets
    • Labels:
      None

      Description

      I think, it is a bad practice don't writing e.getMessage() when writing to log.
      Now Portal Site Manager writes "Failed to get root folder", but I don't know why...
      I've created a patch to log more informative messages.

      1. patch.txt
        0.2 kB
        Vitaly Baranovsky

        Activity

        Vitaly Baranovsky created issue -
        Vitaly Baranovsky made changes -
        Field Original Value New Value
        Attachment patch.txt [ 12367474 ]
        Ate Douma made changes -
        Assignee Ate Douma [ adouma ]
        Hide
        Ate Douma added a comment - - edited

        Vitaly,

        Your patch format was invalid. Don't know how you created it, but Eclipse couldn't apply it.
        Anyway, I've committed a slight different solution as you proposed: by logging the exception instead.

        Show
        Ate Douma added a comment - - edited Vitaly, Your patch format was invalid. Don't know how you created it, but Eclipse couldn't apply it. Anyway, I've committed a slight different solution as you proposed: by logging the exception instead.
        Ate Douma made changes -
        Fix Version/s 2.1.3 [ 12312573 ]
        Fix Version/s 2.2 [ 12312318 ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]

          People

          • Assignee:
            Ate Douma
            Reporter:
            Vitaly Baranovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development