Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.1.3, 2.2.0
    • Component/s: Layout
    • Labels:
      None
    • Environment:
      IE 4.01 Pocket PC ("Pocket IE") Windows CE

      Description

      Currently, we cannot support IE4 on Windows CE, Pocket PC because of the following reason:

      • The current Capability component chooses a media type based on preferred mime type of a client.
        So, if two clients have a same preferred mime type (e.g. text/html), then the second client cannot be treated with a different media type.
        That is, the preferred mime type of IE4 on Pocket PC is as same as that of other general web browser. It's not possible to show different layout decoration and page for Pocket IE.
      1. ie4ppc.diff
        93 kB
        Woonsan Ko

        Activity

        Hide
        Woonsan Ko added a comment -

        After discussion with David Sean Taylor, I decided to do the followings for the 2.1.3 release:

        • To create a valve named 'capabilityCustomizerValve', which would change the preferred mediaType of the capabilityMap and the requestContext just after the capabilityValve finished.
          This valve should decide the mediaType based on the given client-to-mediaType mappings as a
          constructor argument. For example, "ie4ppc (client name) to html-basic (media type name)".
          Also add some seed data for Pocket IE (mediaType and client).

        We will review more for better solution and consider reworking it for the 2.2 release.
        (So, I will not commit to the /trunk.)

        I attached a patch for this solution for the 2.1.3 release.

        How to test to support Pocket IE:
        (1) Install JS 2.1.3.
        (2) Add 'capabilityCustomizerValve' references to the pipelines after the 'capabilityValve'.
        (3) Start JS2
        (4) Visit the default page with Pocket IE.
        (I actually tested with an emulator. Download from http://www.microsoft.com/downloads/details.aspx?FamilyID=A120E012-CA31-4BE9-A3BF-B9BF4F64CE72&displaylang=en )
        (By the way, you should bear in mind to use the emulator:

        • Check 'Use LAN (no autodial)' in the Tools/Option/Connection.
        • Don't visit with 'http://localhost:8080/jetspeed'. Use IP address instead.)

        I'd like to commit this work next week after some more testings.

        Show
        Woonsan Ko added a comment - After discussion with David Sean Taylor, I decided to do the followings for the 2.1.3 release: To create a valve named 'capabilityCustomizerValve', which would change the preferred mediaType of the capabilityMap and the requestContext just after the capabilityValve finished. This valve should decide the mediaType based on the given client-to-mediaType mappings as a constructor argument. For example, "ie4ppc (client name) to html-basic (media type name)". Also add some seed data for Pocket IE (mediaType and client). We will review more for better solution and consider reworking it for the 2.2 release. (So, I will not commit to the /trunk.) I attached a patch for this solution for the 2.1.3 release. How to test to support Pocket IE: (1) Install JS 2.1.3. (2) Add 'capabilityCustomizerValve' references to the pipelines after the 'capabilityValve'. (3) Start JS2 (4) Visit the default page with Pocket IE. (I actually tested with an emulator. Download from http://www.microsoft.com/downloads/details.aspx?FamilyID=A120E012-CA31-4BE9-A3BF-B9BF4F64CE72&displaylang=en ) (By the way, you should bear in mind to use the emulator: Check 'Use LAN (no autodial)' in the Tools/Option/Connection. Don't visit with 'http://localhost:8080/jetspeed'. Use IP address instead.) I'd like to commit this work next week after some more testings.
        Hide
        Ate Douma added a comment -

        Adding this feature to the 2.2 trunk as well to get it inline with the 2.1.3 release features.
        Maybe it needs to be revisited for 2.2, but then better after the codebase is properly synchronized.
        Will commit the 2.1.3 changes to trunk shortly.

        Show
        Ate Douma added a comment - Adding this feature to the 2.2 trunk as well to get it inline with the 2.1.3 release features. Maybe it needs to be revisited for 2.2, but then better after the codebase is properly synchronized. Will commit the 2.1.3 changes to trunk shortly.

          People

          • Assignee:
            Woonsan Ko
            Reporter:
            Woonsan Ko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development