[JS2-619] Non-thread safe code in PortalSiteRequestContextImpl.java

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1-dev
• Component/s: Components Core
• Environment: Any environment.
• Assignee: David Sean Taylor
• Reporter: Woonsan Ko
• Created: 04/Dec/06 12:27
• Updated: 04/Oct/11 21:38
• Resolved: 08/Dec/06 18:26

Description

Every header.vm calls $site.getMenu(...) to retreive menus for a folder.
And the class, named 'org.apache.jetspeed.portalsite.impl.PortalSiteRequestContextImpl', manages a set and a map to store and query portlet definition names and menus.

However, because those are instantiated as a HashSet and as a HashMap, JS2 can throw ConcurrentModificationException when portlet definitions and menus are to be cached.

This exception can be observed in the following case:

• For some reason, user can request twice for the same folder.
• For some reason, a developer can design the pages to call header.vm simultaneously.
  (Actually these situations are not usual and it may not occur after first visit for a folder, but it can occur.)

Therefore, those are to be synchronized.