Jetspeed 2
  1. Jetspeed 2
  2. JS2-614

Jetspeed Deploy compliant with servlet spec 2.4

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1-dev
    • Fix Version/s: 2.1-dev, 2.1
    • Component/s: Project Build
    • Labels:
      None

      Description

      I'm using JetspeedDeploy to automatically make my portlet application ready for Jetspeed.
      JetspeedDeploy adds the JetspeedContainerServlet and the portlet taglib in the web.xml. I works fine as long as I use the servlet specification 2.3.

      But JetspeedDeploy is not able to be compliant with the servlet specification 2.4.
      For example in 2.4 spec, the <taglib> element must be child of the <jsp-config> element, and JetspeedDeploy puts <taglib> directly under <web-app>.
      It causes problem under Websphere.

        Activity

        Nicolas Dutertry created issue -
        Ate Douma made changes -
        Field Original Value New Value
        Assignee Ate Douma [ adouma ]
        Hide
        Nicolas Dutertry added a comment -

        Proposal for a solution

        Show
        Nicolas Dutertry added a comment - Proposal for a solution
        Nicolas Dutertry made changes -
        Attachment jetspeed-deploy-patch.zip [ 12345546 ]
        Hide
        Ate Douma added a comment -

        I've changed this issue from Bug to Improvement. Portlet spec JSR-168 requires (only) compliance with Servlet spec 2.3, so this issue is not some "specs" violation
        The patch is great though and I've tested it out with several different web.xml versions and configurations.
        Will commit the patch (with a small further enhancement, checking if a portlet.tld already exists in the war file) in a minute or so.

        Thanks a lot Nicolas

        Show
        Ate Douma added a comment - I've changed this issue from Bug to Improvement. Portlet spec JSR-168 requires (only) compliance with Servlet spec 2.3, so this issue is not some "specs" violation The patch is great though and I've tested it out with several different web.xml versions and configurations. Will commit the patch (with a small further enhancement, checking if a portlet.tld already exists in the war file) in a minute or so. Thanks a lot Nicolas
        Ate Douma made changes -
        Fix Version/s 2.1-dev [ 12310686 ]
        Summary Jetspeed Deploy not compliant with servlet spec 2.4 Jetspeed Deploy compliant with servlet spec 2.4
        Priority Major [ 3 ] Minor [ 4 ]
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Fix Version/s 2.1 [ 12310617 ]
        Hide
        Ate Douma added a comment -

        Patch applied

        Show
        Ate Douma added a comment - Patch applied
        Ate Douma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ate Douma added a comment -

        Patch broke maven-2 build

        Show
        Ate Douma added a comment - Patch broke maven-2 build
        Ate Douma made changes -
        Status Resolved [ 5 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Hide
        Ate Douma added a comment -

        Fixed maven-2 build by adding commons-lang build dependency.

        Show
        Ate Douma added a comment - Fixed maven-2 build by adding commons-lang build dependency.
        Ate Douma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ate Douma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ate Douma
            Reporter:
            Nicolas Dutertry
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development