Jetspeed 2
  1. Jetspeed 2
  2. JS2-571

Changes to page structure (PSML) using the DatabasePageManager are not reflected to the internal page representation.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1-dev
    • Fix Version/s: 2.1-dev, 2.1
    • Component/s: Other
    • Labels:
      None

      Description

      Changes to page structure (PSML) using the DatabasePageManager are not reflected to the internal page representation when a user configures the page. Thus changing of the configuration of a page has no effect until the page will be reread from the database (i.e. after new login of the user).

      Reason:

      When updating a page with the DatabasePageManager.update(page) method the parent folders page cache is not refreshed. The changed data IS stored to the database though.

      Solution:

      Reset page cache in parent folder (FolderImpl.resetPages(false)). See patch.txt.

      1. patch.txt
        1 kB
        Joachim Müller
      2. page-manager-collection-reset-patch.txt
        6 kB
        Randy Watler

        Activity

        Hide
        Ate Douma added a comment -

        Closed again now properly recorded against Fix Version 2.1 as well

        Show
        Ate Douma added a comment - Closed again now properly recorded against Fix Version 2.1 as well
        Hide
        David Sean Taylor added a comment -

        Patch applied, passes unit tests, accepted by reporter.

        Show
        David Sean Taylor added a comment - Patch applied, passes unit tests, accepted by reporter.
        Hide
        Joachim Müller added a comment -

        This patch works for me. Thanks!

        Show
        Joachim Müller added a comment - This patch works for me. Thanks!
        Hide
        David Sean Taylor added a comment -

        patch applied (2nd), unit tests pass. Joachim, could you please test and verify if this works for you, thanks

        Show
        David Sean Taylor added a comment - patch applied (2nd), unit tests pass. Joachim, could you please test and verify if this works for you, thanks
        Hide
        Randy Watler added a comment -

        Here is a stronger/generalized version of this patch. Due to a lack to time on my part, this has not been compiled or tested, (sorry). Please test if you can David/Joachim.

        Show
        Randy Watler added a comment - Here is a stronger/generalized version of this patch. Due to a lack to time on my part, this has not been compiled or tested, (sorry). Please test if you can David/Joachim.
        Hide
        Randy Watler added a comment -

        AFAICT, there is only one scenario where this might happen: if the page fell out of the cache but remained in the folder page collection. In that case I can see where the added code would help clean things up. I am still pondering the patch, but it should be applied more widely, (to folders and links), if we go for it.

        Show
        Randy Watler added a comment - AFAICT, there is only one scenario where this might happen: if the page fell out of the cache but remained in the folder page collection. In that case I can see where the added code would help clean things up. I am still pondering the patch, but it should be applied more widely, (to folders and links), if we go for it.
        Hide
        David Sean Taylor added a comment -

        Im actually see the opposite of this problem. Fragments are being deleted from the object collections in memory, but not from the database, intermittently, but more often than not, seeing the error. Im not seeing what you described.

        Show
        David Sean Taylor added a comment - Im actually see the opposite of this problem. Fragments are being deleted from the object collections in memory, but not from the database, intermittently, but more often than not, seeing the error. Im not seeing what you described.

          People

          • Assignee:
            David Sean Taylor
            Reporter:
            Joachim Müller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development