Jetspeed 2
  1. Jetspeed 2
  2. JS2-521

j2-admin: Styling of login error messages (Login.jsp)

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1-dev
    • Fix Version/s: 2.1-dev, 2.1
    • Component/s: Admin Portlets
    • Labels:
      None
    • Environment:
      windows xp, tomcat 5.5.16, jetspeed-21-dev build from src

      Description

      I've creaated a new sample portal (myportal) from source.
      Is it possible to add more styling to the admin-portlets?
      For example in login.jsp:

      actual code:
      <c:choose>
      <c:when test="$

      {not empty errorCode}">
      <br>
      <i><fmt:message key="login.label.ErrorCode.${errorCode}"/></i>
      <br>
      </c:when>
      <c:otherwise>
      <c_rt:set var="retryCount" value="<%=((RequestContext)request.getAttribute(RequestContext.REQUEST_PORTALENV)).getSessionAttribute(LoginConstants.RETRYCOUNT)%>"/>
      <c:if test="${not empty retryCount}">
      <br>
      <i><fmt:message key="login.label.InvalidUsernameOrPassword"><fmt:param value="${retryCount}"/></fmt:message></i>
      <br>
      </c:if>
      </c:otherwise>
      </c:choose>

      my wish (formatted error-msg with portlet-msg style):
      <div class="portlet-msg-alert">
      <c:choose>
      <c:when test="${not empty errorCode}

      ">
      <fmt:message key="login.label.ErrorCode.$

      {errorCode}

      "/>
      </c:when>
      <c:otherwise>
      <c_rt:set var="retryCount" value="<%=((RequestContext)request.getAttribute(RequestContext.REQUEST_PORTALENV)).getSessionAttribute(LoginConstants.RETRYCOUNT)%>"/>
      <c:if test="$

      {not empty retryCount}

      ">
      <fmt:message key="login.label.InvalidUsernameOrPassword"><fmt:param value="$

      {retryCount}

      "/></fmt:message>
      </c:if>
      </c:otherwise>
      </c:choose>
      </div>

      Or, can I override such sites in a way like I can override (example default-page.psml) with my own styles

        Activity

        Hide
        Bruno Marti added a comment -

        My wish has a wrong jsp programming, here the better way (hope so):
        <c:choose>
        <c:when test="$

        {not empty errorCode}

        ">
        <br>
        <div class="portlet-msg-alert">
        <fmt:message key="login.label.ErrorCode.$

        {errorCode}

        "/>
        </div>
        <br>
        </c:when>
        <c:otherwise>
        <c_rt:set var="retryCount" value="<%=((RequestContext)request.getAttribute(RequestContext.REQUEST_PORTALENV)).getSessionAttribute(LoginConstants.RETRYCOUNT)%>"/>
        <c:if test="$

        {not empty retryCount}

        ">
        <br>
        <div class="portlet-msg-alert">
        <fmt:message key="login.label.InvalidUsernameOrPassword"><fmt:param value="$

        {retryCount}

        "/></fmt:message>
        </div>
        <br>
        </c:if>
        </c:otherwise>
        </c:choose>

        Show
        Bruno Marti added a comment - My wish has a wrong jsp programming, here the better way (hope so): <c:choose> <c:when test="$ {not empty errorCode} "> <br> <div class="portlet-msg-alert"> <fmt:message key="login.label.ErrorCode.$ {errorCode} "/> </div> <br> </c:when> <c:otherwise> <c_rt:set var="retryCount" value="<%=((RequestContext)request.getAttribute(RequestContext.REQUEST_PORTALENV)).getSessionAttribute(LoginConstants.RETRYCOUNT)%>"/> <c:if test="$ {not empty retryCount} "> <br> <div class="portlet-msg-alert"> <fmt:message key="login.label.InvalidUsernameOrPassword"><fmt:param value="$ {retryCount} "/></fmt:message> </div> <br> </c:if> </c:otherwise> </c:choose>
        Hide
        Bruno Marti added a comment -

        In addition, what's about the styling for the form (fields and button)?
        Should we set there for e.x button class="portlet-form-button", for a input field "portlet-form-field"?

        Show
        Bruno Marti added a comment - In addition, what's about the styling for the form (fields and button)? Should we set there for e.x button class="portlet-form-button", for a input field "portlet-form-field"?
        Hide
        Ate Douma added a comment -

        Implemented

        Show
        Ate Douma added a comment - Implemented

          People

          • Assignee:
            Ate Douma
            Reporter:
            Bruno Marti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development