Jetspeed 2
  1. Jetspeed 2
  2. JS2-482

PSML documents whose names contain diacritic characters are not displayed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0-FINAL
    • Fix Version/s: 2.2.0
    • Component/s: Layout, PSML
    • Labels:
      None
    • Environment:
      win xp pro sp2, tomcat 5.5.12, postgres

      Description

      PSML documents whose names contain diacritic characters are not displayed. If a users creates such a document (e.g. page) with J2 administrative mechanisms or manually as a file it appears in a portal but is not rendered. I cannot see any error logs about it as if the resource was not found at all. I guest it has something to do with URL encoding.
      I've noticed the problem on windows, where cp1250 encoding was used. It might not appear if the OS and Jetspeed encodings are the same.

        Activity

        Hide
        Woonsan Ko added a comment -

        I fixed the url generation for each page node by doing url-encoding of each path component with ISO-8859-1 encoding.
        I haven't tested with site manager yet because it has been refactored a lot with Wicket.
        However, when I add a page with a name containing diacritic character such as ó, it works fine.
        By the way, if I create a page in the page customizer with the same name, the page is actually created by another styled name.
        For example, if I put 'helloó.psml', then the physical file is saved as 'hello_C3_B3.psml'. In this case, there's no problem with the customizer.
        It is a nice feature because it provides more safe page file generation.
        Anyway, if a page is manually created with diacritic characters, then it can be served correctly now by proper url encoding.
        By the way, I think that the portal site manager should work as same as the page customizer.

        Show
        Woonsan Ko added a comment - I fixed the url generation for each page node by doing url-encoding of each path component with ISO-8859-1 encoding. I haven't tested with site manager yet because it has been refactored a lot with Wicket. However, when I add a page with a name containing diacritic character such as ó, it works fine. By the way, if I create a page in the page customizer with the same name, the page is actually created by another styled name. For example, if I put 'helloó.psml', then the physical file is saved as 'hello_C3_B3.psml'. In this case, there's no problem with the customizer. It is a nice feature because it provides more safe page file generation. Anyway, if a page is manually created with diacritic characters, then it can be served correctly now by proper url encoding. By the way, I think that the portal site manager should work as same as the page customizer.
        Hide
        Ate Douma added a comment -

        Vivek, can you review this issue again and check if its still valid, otherwise close it?

        Show
        Ate Douma added a comment - Vivek, can you review this issue again and check if its still valid, otherwise close it?

          People

          • Assignee:
            Woonsan Ko
            Reporter:
            Jacek Wi?licki
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development