Jetspeed 2
  1. Jetspeed 2
  2. JS2-472

FragmentImpl.getFragments() can be null but is assumed not null

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2.0
    • Fix Version/s: 2.1.3, 2.2.0
    • Component/s: None
    • Labels:
      None

      Description

      org.apache.jetspeed.om.page.psml.FragmentImpl.getFragments() can return null if all fragments fail the security check: see line 560.

      However, ContentFragmentImpl assumes that a non-null value is returned: for instance in ContentFragmentList.duplicateList().

      I assume the best fix is to always return a list, even if empty.

      I will supply a patch in the next day or two.

      1. FragmentImpl.diff
        11 kB
        David Jencks
      2. JS2-472-FragmentImpl.diff
        3 kB
        David Jencks

        Activity

        David Jencks created issue -
        David Jencks made changes -
        Field Original Value New Value
        Attachment FragmentImpl.diff [ 12322153 ]
        David Jencks made changes -
        Attachment JS2-472-FragmentImpl.diff [ 12322469 ]
        Randy Watler made changes -
        Assignee Randy Watler [ rwatler ]
        Ate Douma made changes -
        Assignee Randy Watler [ rwatler ]
        David Sean Taylor made changes -
        Assignee Randy Watler [ rwatler ]
        David Sean Taylor made changes -
        Fix Version/s 2.2.0 [ 12312318 ]
        Affects Version/s 2.1.3 [ 12312573 ]
        Affects Version/s 2.2.0 [ 12312318 ]
        Affects Version/s 2.1-dev [ 12310686 ]
        Randy Watler made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.1.3 [ 12312573 ]
        Resolution Fixed [ 1 ]
        Ate Douma made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Randy Watler
            Reporter:
            David Jencks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development