Uploaded image for project: 'Jetspeed 2'
  1. Jetspeed 2
  2. JS2-472

FragmentImpl.getFragments() can be null but is assumed not null

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2.0
    • Fix Version/s: 2.1.3, 2.2.0
    • Component/s: None
    • Labels:
      None

      Description

      org.apache.jetspeed.om.page.psml.FragmentImpl.getFragments() can return null if all fragments fail the security check: see line 560.

      However, ContentFragmentImpl assumes that a non-null value is returned: for instance in ContentFragmentList.duplicateList().

      I assume the best fix is to always return a list, even if empty.

      I will supply a patch in the next day or two.

        Attachments

        1. JS2-472-FragmentImpl.diff
          3 kB
          David Jencks
        2. FragmentImpl.diff
          11 kB
          David Jencks

          Activity

            People

            • Assignee:
              rwatler Randy Watler
              Reporter:
              djencks David Jencks
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: