[JS2-1294] Concurrency Issue with SessionPathResolverCache

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0, 2.2.1, 2.2.2
• Fix Version/s: 2.2.3, 2.3.0
• Component/s: Components Core
• Environment: websphere, IBM Java
• Assignee: David Sean Taylor
• Reporter: Joachim Mueller
• Created: 05/Feb/14 20:32
• Updated: 12/Jul/14 18:07
• Resolved: 02/Jun/14 15:18

Description

A race condition can occur in SessionPathResolverCache since the internal cache is initialized with a non-threadsave HashMap.

Under websphere we can observe blocking threads while accessing the map at:
...
at java/util/HashMap.findNonNullKeyEntry(HashMap.java:601(Compiled Code))
at java/util/HashMap.getEntry(HashMap.java:585(Compiled Code))
at java/util/HashMap.get(HashMap.java:571(Compiled Code))
at org/apache/jetspeed/decoration/caches/HashMapPathResolverCache.getPath(HashMapPathResolverCache.java:49(Compiled Code))
...

The base class HashMapPathResolverCache is not used and can be removed completely, all methods can be migrated to SessionPathResolverCache.

Additional a spelling typo has been fixed.

patch follows...