[JS2-1031] Ldap AttributeBasedRelationDAO class gets NullPointerException when trying to create a relation between two ldap entities

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.2.1
• Component/s: LDAP
• Environment: Windows XP, JRE 1.6.0.11, Tomcat 6.0.18, Apache DS 1.0.2
• Assignee: Ate Douma
• Reporter: Aysegul Aydin Isiktekin
• Created: 10/Jun/09 07:33
• Updated: 04/Oct/11 21:04
• Resolved: 19/Mar/10 17:31

Description

AttributeBasedRelationDAO class gets NullPointerException when trying to create a relation between two ldap entities. StackTrace is as follows:

-----------------------------------------------------------------------------------------------------------------------------
SEVERE: Servlet.service() for servlet JetspeedContainer threw exception
java.lang.NullPointerException
at org.apache.jetspeed.security.mapping.ldap.dao.impl.AttributeBasedRelationDAO.internalAddRelation(AttributeBasedRelationDAO.java:165)
at org.apache.jetspeed.security.mapping.ldap.dao.impl.AttributeBasedRelationDAO.addRelation(AttributeBasedRelationDAO.java:230)
at org.apache.jetspeed.security.mapping.ldap.dao.DefaultLDAPEntityManager.addRelation(DefaultLDAPEntityManager.java:88)
at org.apache.jetspeed.security.spi.impl.JetspeedPrincipalLdapAssociationStorageManager.addAssociation(JetspeedPrincipalLdapAssociationStorageManager.java:56)
...more
-----------------------------------------------------------------------------------------------------------------------------

To fix the problem AttributeBasedRelationDAO class line 164 (internalAddRelation method body) should be changed from:
--------------------------------------------
if(relationAttribute == null)

{ fromEntity.setAttribute(this.relationAttribute,new ArrayList<String>()); }

--------------------------------------------
to:
--------------------------------------------
if (relationAttribute == null)

{ fromEntity.setAttribute(this.relationAttribute, new ArrayList<String>()); relationAttribute = fromEntity.getAttribute(this.relationAttribute); }

--------------------------------------------

Just setting the attribute leaves relationAttribute NULL, causing the NPE.