Uploaded image for project: 'Jetspeed (Retired)'
  1. Jetspeed (Retired)
  2. JS1-372

[PATCH] FileServerPortlet not designed for subclassing

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Resolution: Fixed
    • 1.4b4
    • 1.6-dev
    • Portlets
    • None
    • Operating System: All
      Platform: All
    • 22184

    Description

      The FileServerPortlet sets the content inside it's init() method. Since it is
      good practice to for subclasses to always call super.init(), a subclass of
      FileServerPortlet will get its content set before it can do any processing.

      In addition, the getURL(String) method is defined as private with makes it
      harder to overwrite.

      Attached to this enhancement report is a diff file which does the following to
      make this class more extensible:

      1) Move the setContent call to a separate protected method, initContent.
      2) Make the getURL method protected.
      3) Added some more javadoc comments.

      Attachments

        Activity

          People

            Unassigned Unassigned
            monroe@dukece.com G Monroe
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: