[JEXL-189] Possible bug in Interpreter.isCancelled()

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0
• Fix Version/s: 3.1
• Assignee: Henri Biestro
• Reporter: Dmitri Blinov
• Created: 01/Feb/16 12:06
• Updated: 29/Jun/21 06:59
• Resolved: 23/Feb/16 18:06

Description

Reported by FindBugs is the message:

"Questionable use of non-short-circuit logic in org.apache.commons.jexl3.internal.Interpreter.isCancelled()"

    protected boolean isCancelled() {
        if (cancelled | Thread.interrupted()) {
            cancelled = true;
        }
        return cancelled;
    }

Maybe it is better to replace method as

    protected boolean isCancelled() {
        if (Thread.interrupted())
            cancelled = true;

        return cancelled;
    }