[JENA-2084] Error in documentation of RDF Thrift format

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Jena 4.0.0
• Fix Version/s: Jena 4.1.0
• Component/s: Documentation
• Assignee: Andy Seaborne
• Reporter: Jon
• Created: 10/Apr/21 00:50
• Updated: 04/Jun/21 12:53
• Resolved: 17/May/21 09:16

Description

Both https://jena.apache.org/documentation/io/rdf-binary.html 
and the page that it links to https://afs.github.io/rdf-thrift/rdf-binary-thrift.html 
define RDF literals as:

struct RDF_Literal {
1: required string lex
2: optional string datatype
3: optional string langtag
} 

however the definition in the codebase appears to be:
https://github.com/apache/jena/blob/9519c65f8f5c377d3d9a3983eaaceeb26a99554c/jena-arq/Grammar/RDF-Thrift/BinaryRDF.thrift#L48-L53

struct RDF_Literal {
1: required string  lex ;
2: optional string  langtag ;
3: optional string  datatype ;          // Either 3 or 4 but UNION is heavy.
4: optional RDF_PrefixName dtPrefix ;   // datatype as prefix name
} 

with langtag and datatype swapped, etc.

Perhaps these documentation pages should also link to the latest BinaryRDF.thrift file in source control?

Issue Links

• links to: GitHub Pull Request #51