[JENA-1654] Use StringBuilder in LiteralImpl#asNumber

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Jena 3.9.0
• Fix Version/s: Jena 3.10.0
• Component/s: Core
• Flags: Patch
• Assignee: Bruno P. Kinoshita
• Reporter: Bruno P. Kinoshita
• Created: 29/Dec/18 05:50
• Updated: 02/Jan/19 23:47
• Resolved: 29/Dec/18 21:50

Description

Trivial fix, but replaces strings concatenations by a StringBuilder. Another change (which originated this work) is the removal of the unused local variable "type".

Added a unit test for asNumber (working branch), and another when the value of the literal is not a Number. Also verified that the exception contains parts of the text expected in the error message. The test runs fine before the patch, and after the patch.