[JENA-1495] Covariant return type for Model's PrefixMapping methods.

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Jena 3.6.0
• Fix Version/s: Jena 3.7.0
• Component/s: Core
• Labels: easyfix
• Assignee: Adam Soroka
• Reporter: Adam Jacobs
• Created: 28/Feb/18 01:58
• Updated: 09/Apr/18 21:52
• Resolved: 09/Mar/18 15:30

Description

The Model interface inherits several methods from PrefixMapping which return this.
The return type of these methods can be refined to allow call chaining with the Model object.

There appear to be two concrete implementations of Model which override the PrefixMapping methods: ModelCom and SecuredModelImpl. Steps to add covariant return types for prefix mapping are as follows.

Add these six methods to the Model interface.

1. Model setNsPrefix( String prefix, String uri );
2. Model removeNsPrefix( String prefix );
3. Model clearNsPrefixMap();
4. Model setNsPrefixes( PrefixMapping other );
5. Model setNsPrefixes( Map<String, String> map );
6. Model withDefaultMappings( PrefixMapping map );

...and update ModelCom accordingly.

Add these six methods to the SecuredModel interface.

1. SecuredModel setNsPrefix( String prefix, String uri );
2. SecuredModel removeNsPrefix( String prefix ); // This method is already defined.
3. SecuredModel clearNsPrefixMap();
4. SecuredModel setNsPrefixes( PrefixMapping other );
5. SecuredModel setNsPrefixes( Map<String, String> map );
6. SecuredModel withDefaultMappings( PrefixMapping map );

...and update SecuredModelImpl accordingly.

Issue Links

• links to: GitHub Pull Request #368